WIP: Inject tls policy results #3151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reusable infrastructure for reading and watching OpenShift's APIServer TLS security profile configuration: - tlsprofile.go: Functions to fetch TLS config from APIServer and convert OpenSSL cipher names to IANA format. Includes TLS 1.3 cipher support copied from library-go (see TODO comments for future cleanup). - apiserver_watch.go: Generic watch mechanism that triggers component reconciliation when cluster TLS policy changes. - lister_adapters.go: Generic adapter using Go generics to convert typed listers to ResourceLister interface for all Tekton component types. - RBAC: Added permissions to read apiservers.config.openshift.io Note: TLS cipher conversion functions are copied from library-go to include TLS 1.3 support without requiring dependency upgrades that conflict with current k8s versions. These should be replaced with library-go imports once Tekton components upgrade to k8s 0.34+.
Activate the TLS profile infrastructure for the Results component: - extension.go: Add injectTLSConfig transformer that injects TLS_MIN_VERSION and TLS_CIPHER_SUITES env vars into the Results API deployment based on cluster APIServer configuration. TLS config is fetched once during Transformers() call, not per-resource. - controller.go: Set up APIServer watch to trigger reconciliation when the cluster TLS security profile changes. The Results API deployment will automatically pick up TLS configuration from the OpenShift APIServer resource and update when it changes.
tekton-robot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/XXL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The change include two commits. The first one adds generic TLS profiles centrally managed on the cluster level as OpenShift APIServer resources. It allows each Tekton component to use that functionality and set the TLS policy for their services.
The second change enables the centralized TLS profile for Tekton Results.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes