TSP-412-Change the Connection Address of a saved instrument #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esarver
requested changes
Jan 2, 2026
|
|
||
| public async updateIPAddr(item: Connection) { | ||
| const newIP = await vscode.window.showInputBox({ | ||
| placeHolder: "Enter new IP address", |
Member
There was a problem hiding this comment.
Can we make this function inclusive for changing any address type? We also support VISA resource strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IP address of instruments can change frequently. On running discovery, if a change in IP address is detected, the same automatically changes for the saved instrument in the instrument treeview. Along with this, the IP address of the saved instrument can be changed manually using the 'update IP address' option (pencil icon) present in the IP address item of the treeview.