Image width and height should not be forced in the component.#7
Image width and height should not be forced in the component.#7teleject merged 1 commit intoteleject:masterfrom
Conversation
mvsusp
commented
May 23, 2015
- The library should no be responsible to resize the component.
- The library should no be responsible to resize the component.
|
@mvsusp can you clarify or describe what happens in Safari that happens with the existing code? |
|
@teleject Have the same problem @mvsusp seems to have removed these lines for. When you resize the browser window, the images loaded with hiSrc experience strange stretching artifacts im my case. Here's a gif showing the problem ('wrong behaviour'): You might consider removing them too, but I can't test in Safari to see what they are supposed to fix, unfortunately. Any chance you can work around that? For now I'll simply comment these lines. |
|
Thanks man!
…On Thu, Feb 9, 2017 at 11:52 AM Christopher Schmitt < ***@***.***> wrote:
Cool. Thanks for the clarification, @Seneral <https://github.com/Seneral>
and @mvsusp <https://github.com/mvsusp>. Will look into it when I get a
moment and more than likely update the code!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAIq-kYqIR16DuXKUzhE0WkMOj7-STqkks5ra0RkgaJpZM4EmiX6>
.
|
|
Great, thanks! Also made some other changes #8 since then which solves some implementation issues of the speed test. |
