This repository was archived by the owner on Feb 17, 2022. It is now read-only.
Add a configuration parameter for setting escalation wait times per-task.#4
Open
GeorgeSirois wants to merge 1 commit intomasterfrom
Open
Add a configuration parameter for setting escalation wait times per-task.#4GeorgeSirois wants to merge 1 commit intomasterfrom
GeorgeSirois wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
I think that the escalation times for /qqq->/aaa and /aaa->kill should be independently configurable - every situation in which I have seen the need to configure this so far has been isolated to the /qqq->/aaa stage.
Author
|
Hm, ok. Easy enough to change. |
GeorgeSirois
force-pushed
the
configurable-executor-escalation-wait
branch
from
0deb543 to
c90532d
Compare
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ThanosBaskous @steveniemitz
PR just to review.