(trivial) Make sdk-general.json dashboard title consistent with server-general.json #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json I noticed that the dashboard title of sdk-general.json is "SDK Metrics", where the dashboard title of sever-general.json is "Temporal Server Metrics". For consistency, would you consider changing the sdk-general.json dashboard title to "Temporal SDK Metrics"?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the dashboard title of sdk-general.json is "SDK Metrics", where the dashboard title of sever-general.json is "Temporal Server Metrics". For consistency, would you consider changing the sdk-general.json dashboard title to "Temporal SDK Metrics"?
What was changed
sdk-general.json dashboard title changed from "SDK Metrics" to "Temporal SDK Metrics".
Why?
To be consistent with server-general.json's title. I went looking for the SDK dashboard after deploying it and couldn't find it searching for "temporal".
Checklist
How was this tested:
Any docs updates needed?
I don't think so.