Include Expected Outputs to Hello World Sample

[KeithB-Temporal]

What was changed

Documentation Change only. Update the README.md to 1) Include expected outputs, 2)Add instruction to create the default namespace if it does not exist, 3) Highlight that the run workers command is a blocking command (so run in another window),

Why?

Because sample instructions should be unambiguous about what success looks like and have helpful tips to aid in running. It should should aspire to the don't make me think principle.

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[yuandrew]

Thanks for the improvement! Some cleaning up to do, but overall agree it's helpful for samples to give expected output so users know it was run successfully.

[yuandrew]

This log seems unrelated to the sample, it's running a workflow named temporal-sys-history-scanner-workflow

[KeithB-Temporal]

Correct, those are validation instructions for the user to know that the server is up and running successfully. Agree it is more related to the server up and running, but I think that for a Hello World sample it is okay to have extra validation info to save the user jumping back and forth between this doc and the Temporal Server doc. WDYT?

[yuandrew]

This line isn't related to the server running though, but instead that a workflow has run. So far in the instructions a user hasn't touched a workflow yet. Server output is usually something like

➜  ~ temporal server start-dev
CLI 1.5.1 (Server 1.29.1, UI 2.42.1)

Server:  localhost:7233
UI:      http://localhost:8233
Metrics: http://localhost:53085/metrics

[yuandrew]

(referring to the workflow successfully started and the full log line below, just in case that wasn't clear)

[KeithB-Temporal]

Agreed. That wasn't the correct server output.

I actually was using this sample in conjunction with self building the temporal server (https://github.com/temporalio/temporal/blob/main/CONTRIBUTING.md) so I had different server output (and I think I had pasted the the wrong log line even for that...). That said, this sample should assume that the server is using the CLI to build and run the server, so it should have the output you suggested.

[yuandrew]

default namespace works without manually creating it. I'm not sure it's worth mentioning that non-default namespaces need to be created in this sample. It feels out of the scope of this sample, and we already have this info in docs https://docs.temporal.io/develop/go/namespaces#register-namespace

[KeithB-Temporal]

I agree with you, but https://github.com/temporalio/temporal/blob/main/CONTRIBUTING.md now also directs users to try out the Hello World samples, and when starting the server using those instructions it does not create the default namespace.

I believe the best way to balance these two concerns would be to optimize the guide for the server being started via CLI (don't include the create namespace as a step) but instead include a debugging tip at the bottom for what to do if the Worker won't start because of the missing namespace.

[yuandrew]

Thanks for the improvement! LGTM, one small formatting comment to consider

[yuandrew]

I'm not sure having this all in a NOTE block is necessary, it's already in its own Troubleshooting block.

But great detail to add! TBH I wasn't aware of this fact until now haha