Skip to content

chore: make errors more informative #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xepozz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: make errors more informative #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions tests/Acceptance/App/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

use Google\Protobuf\Timestamp;
use PHPUnit\Framework\SkippedTest;
use PHPUnit\Framework\SkippedWithMessageException;
use PHPUnit\Framework\TestStatus\Skipped;
use Psr\Log\LoggerInterface;
use Spiral\Core\Container;
use Spiral\Core\Scope;
Expand Down Expand Up @@ -36,16 +34,16 @@ protected function setUp(): void

protected function runTest(): mixed
{
$c = ContainerFacade::$container;
$container = ContainerFacade::$container;
/** @var State $runtime */
$runtime = $c->get(State::class);
$runtime = $container->get(State::class);
$feature = $runtime->getFeatureByTestCase(static::class);

// Configure client logger
$logger = LoggerFactory::createClientLogger($feature->taskQueue);
$logger->clear();

return $c->runScope(
return $container->runScope(
new Scope(name: 'feature', bindings: [
Feature::class => $feature,
static::class => $this,
Expand All @@ -62,7 +60,15 @@ function (Container $container): mixed {
return parent::runTest();
} catch (\Throwable $e) {
if ($e instanceof TemporalException) {
echo "\n=== Workflow history for failed test {$this->name()} ===\n";
echo \sprintf(
"\n=== En error occurred while testing %s: %s (%s) ===\n",
static::class . '::' . $this->name(),
$e->getMessage(),
$e::class,
);
echo "\n=== Stack trace ===\n";
echo $e->getTraceAsString();
echo "\n=== Workflow history ===\n";
$this->printWorkflowHistory($container->get(WorkflowClientInterface::class), $args);

$logRecords = $container->get(ClientLogger::class)->getRecords();
Expand Down Expand Up @@ -117,9 +123,7 @@ private function printWorkflowHistory(WorkflowClientInterface $workflowClient, a
? 0
: $ts->getSeconds() + \round($ts->getNanos() / 1_000_000_000, 6);

foreach ($workflowClient->getWorkflowHistory(
$arg->getExecution(),
) as $event) {
foreach ($workflowClient->getWorkflowHistory($arg->getExecution()) as $event) {
$start ??= $fnTime($event->getEventTime());
echo "\n" . \str_pad((string) $event->getEventId(), 3, ' ', STR_PAD_LEFT) . ' ';
# Calculate delta time
Expand Down
Loading