Skip to content

fix: ignore psalm error #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xepozz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: ignore psalm error #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69c6367
fix: ignore psalm error
xepozz Dec 26, 2025
aeb32ca
chore: update psalm baseline
xepozz Jan 9, 2026
69e758f
Merge branch 'master' into psalm
xepozz Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="6.13.1@1e3b7f0a8ab32b23197b91107adc0a7ed8a05b51">
<files psalm-version="6.14.2@bbd217fc98c0daa0a13aea2a7f119d03ba3fc9a0">
<file src="src/Activity.php">
<ImplicitToStringCast>
<code><![CDATA[$type]]></code>
Expand Down
1 change: 1 addition & 0 deletions src/Internal/Promise/CancellationQueue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public function __invoke(): void

private function drain(): void
{
/** @psalm-suppress PossiblyNullArrayOffset */
Copy link
Collaborator

@wolfy-j wolfy-j Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reasoning here?

Copy link
Collaborator Author

@xepozz xepozz Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a separate PR's you may notice that static analysis is failed, e.g. https://github.com/temporalio/sdk-php/actions/runs/20845807591/job/59889027930
image

Copy link
Collaborator

@roxblnfk roxblnfk Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to suppress false positives with annotations. However, this case doesn't seem like a false positive, but to be sure, you need to study the class usage context.
If you still want to put this in the backlog, use psalm:baseline. To fix it, you'll need to rewrite the code.

for ($i = \key($this->queue); isset($this->queue[$i]); $i++) {
$cancellable = $this->queue[$i];

Expand Down
Loading