Skip to content

Conversation

@simvlad
Copy link
Contributor

@simvlad simvlad commented Jan 12, 2026

What changed?

Added TemporalExternalPayloadSizeBytes and TemporalExternalPayloadCount to Visibility Schema as pre-defined search attribute.

Why?

We are planning to expose external payload size and count as the search attributes. They are pre-defined, rather than system, because they won't be set on every single workflow, but only ones which store large payloads externally (e.g. in S3).

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

Incorrectly modified schema

@simvlad simvlad requested review from a team as code owners January 12, 2026 22:06
@simvlad simvlad marked this pull request as draft January 14, 2026 20:54
@simvlad simvlad marked this pull request as ready for review January 14, 2026 22:03
@simvlad simvlad force-pushed the simvlad/add-external-payload-stats-to-visibility branch from cc5e52f to f1ba85c Compare January 15, 2026 17:57
@simvlad simvlad requested a review from rodrigozhou January 15, 2026 18:08
Copy link
Contributor

@rodrigozhou rodrigozhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update

data, err := assets.ReadFile("elasticsearch/visibility/versioned/v13/index_template_v7.json")
for the tests to pass.

@simvlad simvlad force-pushed the simvlad/add-external-payload-stats-to-visibility branch from 360878e to e04f7eb Compare January 21, 2026 23:35
@simvlad simvlad force-pushed the simvlad/add-external-payload-stats-to-visibility branch from e04f7eb to 5602d08 Compare January 23, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants