Nexus caller timeouts #9010
Merged
Nexus caller timeouts #9010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2026
pdoerner
reviewed
Jan 13, 2026
| attrs.ScheduleToCloseTimeout = durationpb.New(maxTimeout) | ||
| } | ||
|
|
||
| // Trim secondary timeouts to the primary timeout. |
Contributor
There was a problem hiding this comment.
Should this also go the other way? If only schedule-to-start or start-to-close is set, but not schedule-to-close, should we set schedule-to-close to one of those timeouts?
IIRC the operation deadline we send to the handler is based only on schedule-to-close timeout, so the handler may not be aware that the operation has a deadline in that case.
Member
Author
There was a problem hiding this comment.
It shouldn't go the other way because the new timeouts are more specific. But you make a good point that the operation timeout header should take the new timeouts into consideration.
bergundy
added a commit
to temporalio/api
that referenced
this pull request
Jan 13, 2026
**What changed?** Add ScheduleToStart and StartToClose timeouts for Nexus operations. **Why?** Give callers more control over timeouts of the various operation lifecycle stages. **Server PR** temporalio/temporal#9010
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
Jan 13, 2026
**What changed?** Add ScheduleToStart and StartToClose timeouts for Nexus operations. **Why?** Give callers more control over timeouts of the various operation lifecycle stages. **Server PR** temporalio/temporal#9010
bergundy
force-pushed
the
nexus-caller-timeouts
branch
from
1316c05 to
a3b0e54
Compare
pdoerner
approved these changes
Jan 13, 2026
bergundy
added a commit
to bergundy/temporal
that referenced
this pull request
Jan 15, 2026
This reverts commit 8f4d4ba.
bergundy
added a commit
that referenced
this pull request
Jan 15, 2026
bergundy
added a commit
to bergundy/temporal
that referenced
this pull request
Jan 15, 2026
This reverts commit 3212fe2.
bergundy
added a commit
that referenced
this pull request
Jan 16, 2026
## What changed? Reapplied #9010. The original PR that introduced these timeouts did not populate the operation-timeout header or set the call context timeout correctly. This PR fixes the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit implements two new granular timeout types for Nexus operations, allowing callers to have fine-grained control over different phases of operation execution:
These timeouts complement the existing Schedule-to-Close Timeout to provide better control and diagnostics for Nexus operation execution.
See the corresponding API PR: temporalio/api#695.