Standalone activities RecordActivityTaskStarted fixes #9115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bergundy
changed the title
bergundy
force-pushed
the
drop-obsolete-saa-matching-task
branch
from
5dac8f4 to
9c9f347
Compare
fretz12
approved these changes
Jan 22, 2026
dandavison
reviewed
Jan 23, 2026
| func(a *Activity, ctx chasm.MutableContext, request *historyservice.RecordActivityTaskStartedRequest) error { | ||
| attempt := a.LastAttempt.Get(ctx) | ||
| attempt.StartedTime = timestamppb.New(ctx.Now(a)) | ||
| attempt.LastWorkerIdentity = request.GetPollRequest().GetIdentity() |
Contributor
There was a problem hiding this comment.
I think we need to capture the request ID from the request here (we only have the unit test).
dandavison
approved these changes
Jan 23, 2026
Contributor
dandavison
left a comment
dandavison
left a comment
There was a problem hiding this comment.
This LGTM apart from accidentally missing setting the requestID in the transition. (The attempt/stamp changes LGTM).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Avoid retrying these tasks invalid tasks and fix idempotency issues.