Patch v1.30.0-148.4 #9121
Merged
Patch v1.30.0-148.4 #9121
+257
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#8978) Update replication task rate limiter priority based on active/standby state The replication task should have higher priority than standby task - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) There is a task processing priority change requires review
## What changed? Make the DeploymentOption fields optional for unversioned worker. ## Why? Ruby SDK is sending empty deployment name by default. The existing checks in server (although compatible with the [protocol](https://github.com/temporalio/api/blob/de624eeedcdc8c2a760e22e4510b93799637ae88/temporal/api/deployment/v1/message.proto#L21)) breaks Ruby SDK's default behavior so we're relaxing it. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Hotfix candidate for 148
temporal-cicd
bot
deleted the
patch-3.148-4661f81d-e742-49cb-b304-7e4cb1e4dbb1
branch
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch release 1.30.0 with PR(s):