Skip to content

Use CountSchedules for counting schedules #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lina-temporal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use CountSchedules for counting schedules #3100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions src/lib/services/workflow-counts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import type { CountWorkflowExecutionsResponse } from '$lib/types/workflows';
import type {
CountSchedulesResponse,
CountWorkflowExecutionsResponse,
} from '$lib/types/workflows';
import { requestFromAPI } from '$lib/utilities/request-from-api';
import { routeForApi } from '$lib/utilities/route-for-api';
import { TASK_FAILURES_QUERY } from '$lib/utilities/workflow-task-failures';
Expand Down Expand Up @@ -73,23 +76,12 @@ export const fetchScheduleCount = async ({
namespace: string;
query?: string;
}): Promise<string> => {
const scheduleFixedQuery =
'TemporalNamespaceDivision="TemporalScheduler" AND ExecutionStatus="Running"';

const fullQuery = query
? `${scheduleFixedQuery} AND ${query}`
: scheduleFixedQuery;
const countRoute = routeForApi('workflows.count', {
const countRoute = routeForApi('schedules.count', {
namespace,
});
const { count } = await requestFromAPI<CountWorkflowExecutionsResponse>(
countRoute,
{
params: {
query: fullQuery,
},
notifyOnError: false,
},
);
const { count } = await requestFromAPI<CountSchedulesResponse>(countRoute, {
params: query ? { query } : {},
notifyOnError: false,
});
return count ?? '0';
};
2 changes: 1 addition & 1 deletion src/lib/types/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export type ParameterlessAPIRoutePath =
| 'nexus-endpoints'
| 'namespaces';
export type WorkerAPIRoutePath = 'worker-task-reachability';
export type SchedulesAPIRoutePath = 'schedules';
export type SchedulesAPIRoutePath = 'schedules' | 'schedules.count';
export type ScheduleAPIRoutePath =
| 'schedule'
| 'schedule.patch'
Expand Down
5 changes: 5 additions & 0 deletions src/lib/types/workflows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ export type CountWorkflowExecutionsResponse = {
groups?: { count: string; groupValues: Payloads }[];
};

export type CountSchedulesResponse = {
count?: string;
groups?: { count: string; groupValues: Payloads }[];
};

export type WorkflowExecutionConfig = Replace<
import('$lib/types').WorkflowExecutionConfig,
{
Expand Down
1 change: 1 addition & 0 deletions src/lib/utilities/route-for-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ export function pathForApi(
'schedule.patch': `/namespaces/${parameters?.namespace}/schedules/${parameters?.scheduleId}/patch`,
'schedule.edit': `/namespaces/${parameters?.namespace}/schedules/${parameters?.scheduleId}/update`,
schedules: `/namespaces/${parameters?.namespace}/schedules`,
'schedules.count': `/namespaces/${parameters?.namespace}/schedule-count`,
settings: '/settings',
'task-queue': `/namespaces/${parameters?.namespace}/task-queues/${parameters?.queue}`,
'task-queue.compatibility': `/namespaces/${parameters?.namespace}/task-queues/${parameters?.queue}/worker-build-id-compatibility`,
Expand Down
Loading