Fix TF-text. #1446
Open
Fix TF-text. #1446
+2,865
−13,567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_847172303
branch
6 times, most recently
from
c0c6000 to
600bdfa
Compare
This is a combination of a collection of changes to fix the TF-text build. All are required
for a successful build.
1. Upgrade ICU to v77.1
- Requires changes to ICU build file, updating ICU data, updating test goldens
- Added `custom_http_archive` rule to allow excluding files.
2. Replace `tensorflow.bzl:pybind_extension` with `tsl.bzl:pybind_extension`
- Forces creation of pybind .so files to include in the wheel.
3. Patch TF build file to exclude `libtensorflow_framework` source files.
- Avoids ODR issues causing double-registrations.
4. Update requirements files
- TF 3.9, 3.10 are somewhat fundamentally broken because of tensorflow-metadata,
which restricts the protobuf version below what TF requires. Though this turns out
not to be a hard requirement, by skipping the requirements.update in `configure` and manually
setting package versions, we can create a successful build.
5. Replace the `build_pip_package.sh` with a python version
- Allows using the hermetic python toolchain to build the wheel. Avoids the need for docker.
6. Fix random missing deps.
PiperOrigin-RevId: 847172303
copybara-service
bot
force-pushed
the
test_847172303
branch
from
600bdfa to
088c641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TF-text.
This is a combination of a collection of changes to fix the TF-text build. All are required
for a successful build.
custom_http_archiverule to allow excluding files.tensorflow.bzl:pybind_extensionwithtsl.bzl:pybind_extensionlibtensorflow_frameworksource files.which restricts the protobuf version below what TF requires. Though this turns out
not to be a hard requirement, by skipping the requirements.update in
configureand manuallysetting package versions, we can create a successful build.
build_pip_package.shwith a python version