Fix whitespace typo for Bert Question Answerer test in README.md#967
Open
ghostfly23333 wants to merge 1 commit intotensorflow:masterfrom
Open
Fix whitespace typo for Bert Question Answerer test in README.md#967ghostfly23333 wants to merge 1 commit intotensorflow:masterfrom
ghostfly23333 wants to merge 1 commit intotensorflow:masterfrom
Conversation
Author
|
Hi @lu-wang-g Asking here for code review as I'm not allowed to assign you as reviewer in the reviewers sidebar. Also if the example is ought to be the origin version, feel free to comment below! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Bert QA testcase provided by README.md, I think the context is seperated by different types of whitespace. I also print the results of the subwords of tokens. It shows these.
So the tokens are not correctly been seperated by the absl::StrSplit() in
tflite-support/tensorflow_lite_support/cc/task/text/bert_question_answerer.cc
Line 205 in 2ab7750
I check the hex values of the origin context string it shows typos about whitespace in the context and I patch the issue.