Added fix to prevent keepalive on non-created leases

[vpapidokha]

Summary by CodeRabbit

• Bug Fixes
  • Improved lease creation process to handle specific status responses more accurately, ensuring smoother user experience when creating leases.

[coderabbitai]

Walkthrough

A conditional check was added to the CreateLease function within the lease management logic. After attempting to create a lease, the function now immediately returns if the lease status is not "created," providing an early exit and skipping the subsequent lease prolongation step. The rest of the function remains unchanged, and no public interfaces were altered.

Changes

File(s)	Change Summary
internal/application/command/leasemanagement/leaseManagement.go	Added a conditional check in CreateLease for early return if lease status is not "created".

Poem

A lease is made, but not always new,
Sometimes "accepted" is the status true.
With a hop and a skip, the code now knows,
When to pause and when it goes.
Early returns, less to prolong,
The rabbit hums a simpler song! 🐇

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

internal/application/command/leasemanagement/leaseManagement.go (1)

38-40: Good fix to prevent unnecessary keepalive operations!

This change ensures we don't try to call KeepLeaseOnce on leases that aren't actually in the "created" status, which aligns with the PR objective. This prevents potential errors or unexpected behavior when trying to extend non-created leases.

For completeness, consider adding a debug log statement before returning, similar to the other operations in this function. This would improve traceability when troubleshooting.

 if leaseStatus != storage.StatusCreated {
+    log.Debugf("Skipping lease prolongation for non-created lease with status: %v, leaseID: %v", leaseStatus, leaseID)
     return "accepted", leaseID, nil
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc4321d and 3623f92.

📒 Files selected for processing (1)

• internal/application/command/leasemanagement/leaseManagement.go (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

internal/application/command/leasemanagement/leaseManagement.go (1)

internal/infrastructure/storage/storage.go (1)

• StatusCreated (9-9)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-and-push