Skip to content

Conversation

@alexytomi
Copy link

No description provided.

@TomJo2000
Copy link
Member

I don't think that commit message quite follows the format we use.
Something like:

fix(api/usb): implement product/vendor ID support
Implement support for options added in API package:
https://github.com/termux/termux-api-package/commit/7531d577ffae5156206ecd8cd193d0d6673c2871

might be closer to the convention,

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough Java to give more than some whitespace formatting changes as suggestions, but this seems reasonable to me.

@alexytomi alexytomi force-pushed the use-product-and-vendor-id-usb branch from 431ac70 to b40a175 Compare December 23, 2025 09:43
@alexytomi
Copy link
Author

I don't think that commit message quite follows the format we use. Something like:

fix(api/usb): implement product/vendor ID support
Implement support for options added in API package:
https://github.com/termux/termux-api-package/commit/7531d577ffae5156206ecd8cd193d0d6673c2871

might be closer to the convention,

I was copying what I saw as the commit history of this repo

That message looks a lot better though, I couldn't think up of a better one, thanks!

@TomJo2000
Copy link
Member

We can't exactly fix bad history but we can always try writing better history in the future.
That commit message suggestion was based on the guidelines we use for termux/termux-packages.

@alexytomi alexytomi force-pushed the use-product-and-vendor-id-usb branch from b40a175 to dd94c3b Compare December 23, 2025 09:54
@alexytomi
Copy link
Author

I don't know enough Java to give more than some whitespace formatting changes as suggestions, but this seems reasonable to me.

I completely forgot to fix the formatting, my bad. Also fixed a few other unrelated formatting errors.

@TomJo2000
Copy link
Member

I completely forgot to fix the formatting, my bad. Also fixed a few other unrelated formatting errors.

It happens.

@alexytomi alexytomi changed the title Fixed(UsbAPI): Use product and vendor ids from https://github.com/termux/termux-api-package/commit/7531d577ffae5156206ecd8cd193d0d6673c2871 Fixed(UsbAPI): Implement product/vendor ID support Dec 23, 2025
@alexytomi
Copy link
Author

I found an issue, this only functions for termux-usb

If someone manually provided only the vendorId with their own termux-api invocation, it would not match for it.

@alexytomi alexytomi marked this pull request as draft December 23, 2025 11:33
@agnostic-apollo
Copy link
Member

Changes for that commit were already implemented in #759 with further enhancements. So closing this.

Termux app and plugins all follow the commit convention defined in https://github.com/termux/termux-app?tab=readme-ov-file#commit-messages-guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants