Improving the flexibility of the shuffling logic #2411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change? Why is it being made?
These changes enable different ARMI applications to share a common shuffling input definition utilizing
ring&positionatcycleinstead ofassemblyName. This is particularly useful for movements where an assembly which has been discharged from the core (e.g. to the spent fuel pool) needs to be reintroduced into the core in a later cycle of operation.Currently, the input format to specify an assembly moving from the spent fuel pool back into the core uses the
assemblyName. However,assemblyName(i.e. assembly number) is not guaranteed to be consistent across ARMI Apps. For example, one App may run a full core model while another leverages core symmetry and models a 1/3 symmetric core model. Both applications should be able to interrogate a common shuffling definition and parse consistent assembly movements.This PR moves spent fuel pool assembly identification away from using the
assemblyName. Instead, the assembly location history is used. The input is nowring,position, andcycle. This is used to identify the target assembly which resided at(ring, position)duringcycle.SCR Information
Change Type: features
One-Sentence Rationale: Different ARMI Applications should be able to share common shuffling input definitions which are independent of application specifics such as assembly numbering.
One-line Impact on Requirements: N/A, this seems to fall under requirement
R_ARMI_SHUFFLEwith new testing covered underT_ARMI_SHUFFLEChecklist
docfolder.pyproject.toml.