Skip to content

Conversation

@john-science
Copy link
Member

@john-science john-science commented Jan 9, 2026

What is the change? Why is it being made?

There were 3 impl tags missing from requirements and 7 test tags. This was due to a combination of two things:

  1. Sphinx / RST formatting errors.
  2. Missing __init__.py files.

I have resolved these issues, as you can see from the PDF in the docs build on GitHub Actions:

image

closes #2417

SCR Information

Change Type: docs

One-Sentence Rationale: All requirements should have both test and impl tags, correct and visible in the docs.

One-line Impact on Requirements: Three requirements had Implementation tags that were not being shown in the docs but are now: R_ARMI_DEPL_TABLES, R_ARMI_DEPL_ABC, and R_ARMI_ASSEM_HEIGHT_PRES. And seven requirements had test tags that were not being rendered in the docs but are now: R_ARMI_GRID_HEX, R_ARMI_GRID_SYMMETRY, R_ARMI_GRID_SYMMETRY_LOC, R_ARMI_GRID_EQUIVALENTS, R_ARMI_GRID_HEX_TYPE, R_ARMI_GRID_GLOBAL_POS, and R_ARMI_GRID_ELEM_LOC.


Checklist

@john-science john-science added the documentation Improvements or additions to documentation label Jan 9, 2026
@john-science john-science requested a review from opotowsky January 9, 2026 16:55
@john-science john-science marked this pull request as ready for review January 9, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some requirements are missing impl or test tags

2 participants