Skip to content

Conversation

@tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Jun 13, 2025

Add missing params to the installation action. This allows CI to validate installation.

Unfortunately we can't start/stop recording because we don't have an API key, so I left the code with dummy values but added continue-on-failure. Filed #11 as follow-up.

@tristanlabelle tristanlabelle marked this pull request as ready for review June 13, 2025 12:59
@tristanlabelle tristanlabelle changed the title Add install params to CI Fix Dashcam installation in CI Jun 13, 2025
@tristanlabelle tristanlabelle requested review from a team and ericclemmons June 13, 2025 13:00
@ericclemmons
Copy link
Contributor

Which API key do you need? I can add one to this repo...

@tristanlabelle
Copy link
Contributor Author

@ericclemmons , ideally we'd have a test key such that we could record and upload a 1s video as part of PR validation / CI. Note that adding a secret to a public repo is tricky from a security perspective. You need to make sure that workflows are not automatically triggered on PRs from folks that don't have write access.

@ericclemmons
Copy link
Contributor

I've restricted it:

Screenshot 2025-06-13 at 11 40 11 AM

Specifically, which env variables do you need set? (e.g. TD_API_KEY, DASHCAM_...?)

@tristanlabelle
Copy link
Contributor Author

We'd need at least an API key, and I think we also need a project ID to be able to stop the recording and upload the file. The name of the variable doesn't matter as long as we can access it from ${{ secrets.VAR }}

@tristanlabelle
Copy link
Contributor Author

@ericclemmons Do I have your ✅ to merge? I'm used to waiting for one approval despite having merge rights, but let me know if we should work otherwise.

@ericclemmons
Copy link
Contributor

@tristanlabelle Oh yessir! I'll go ahead & merge that now...

@ericclemmons ericclemmons merged commit ba68400 into testdriverai:main Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants