Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

Conversation

@SimmonsRitchie
Copy link
Contributor

What's this PR do?

Reverts a previous revert of a PR that fixed a docker build issue that was merged to master. In other words, this PR restores PR #118.

Why are we doing this? How does it help us?

After it was merged to master, PR #117 seemingly caused the failure of a Tribune rundeck job that updates a spreadsheet each day with stats from our database. However, after discussion among the Tribune's engineering team, it remains unclear why that merge would have caused that rundeck job to fail. We theorize that the rundeck job's failure – while still mysterious – may have been a coincidence.

How should this be manually tested?

How should this change be communicated to end users?

Are there any smells or added technical debt to note?

What are the relevant tickets?

Have you done the following, if applicable:

(optional: add explanation between parentheses)

  • Added automated tests? ( )
  • Tested manually on mobile? ( )
  • Checked BrowserStack? ( )
  • Checked for performance implications? ( )
  • Checked accessibility? ( )
  • Checked for security implications? ( )
  • Updated the documentation/wiki? ( )

TODOs / next steps:

  • your TODO here

@SimmonsRitchie SimmonsRitchie merged commit 6eaf9c9 into master Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants