Skip to content

Conversation

@EchterAgo
Copy link
Contributor

@EchterAgo EchterAgo commented Jun 18, 2016

Replace the old RangeEditor and TextBox numeric editors with the new
advanced slider control. The user can use a combination of ALT, CTRL and
SHIFT keys to adjust the rate of change. The user can also double click
the value to edit the value numerically.

Signed-off-by: Axel Gembe axel@gembe.net

This needs #193 merged first.

@EchterAgo
Copy link
Contributor Author

This is a large one. Sadly it can not be used with nullable values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should maybe come from an attribute as well.

@EchterAgo EchterAgo force-pushed the advanced_slider branch 2 times, most recently from eccedf2 to 8932ba8 Compare June 23, 2016 00:31
@EchterAgo
Copy link
Contributor Author

Rebased on top of #192

@EchterAgo EchterAgo force-pushed the advanced_slider branch 9 times, most recently from ddf9a54 to 6cf7cc1 Compare July 1, 2016 11:11
@EchterAgo
Copy link
Contributor Author

Updated patch to make it easier to set the cursor inside the text field and to make the text box use the key down event for ending editing so that other controls do not handle the key down event first.

@EchterAgo
Copy link
Contributor Author

Updated to support keyboard focus

@tgjones
Copy link
Owner

tgjones commented Jul 6, 2016

This looks quite nice. I'm concerned about the overlap with NumericTextBox though (as seen in the MonoGame demo, in the Vector3 property editor). Could we extend NumericTextBox instead of introducting a new control?

In any case, I'll wait till #192 is merged, so that the diff here is easier to review.

@EchterAgo EchterAgo force-pushed the advanced_slider branch 5 times, most recently from 7578cd9 to 45f3aa3 Compare July 9, 2016 05:53
@EchterAgo EchterAgo mentioned this pull request Sep 13, 2016
@EchterAgo
Copy link
Contributor Author

Rebased

@tgjones
Copy link
Owner

tgjones commented Nov 6, 2018

Please could you rebase this again?

@EchterAgo
Copy link
Contributor Author

I'll do that, but I'd like to look into addressing your concerns regarding NumericTextBox overlap first. I think you should take a look at merging #298, it is a simple bugfix.

@EchterAgo EchterAgo force-pushed the advanced_slider branch 3 times, most recently from 1234489 to 3249508 Compare November 8, 2018 10:10
Replace the old RangeEditor and TextBox numeric editors with the new
advanced slider control. The user can use a combination of ALT, CTRL and
SHIFT keys to adjust the rate of change. The user can also double click
the value to edit the value numerically.

Signed-off-by: Axel Gembe <axel@gembe.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants