Open
Conversation
emilyschell
requested changes
May 13, 2022
Collaborator
emilyschell
left a comment
emilyschell
left a comment
There was a problem hiding this comment.
Great work, it mostly works kinda! Love your story line! Commented on a few areas for improvement.
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
Collaborator
There was a problem hiding this comment.
Use python comment syntax: # (also lines 5, 12, 22)
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): |
Collaborator
There was a problem hiding this comment.
Consider how many times this loop will run.
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
| loop = 1 | ||
| while (loop < 9): | ||
| // All the questions that the program asks the user | ||
| noun = input("Choose a noun: ") |
Collaborator
There was a problem hiding this comment.
Consider making each code section into a function/helper function for readability/organization.
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") |
Collaborator
There was a problem hiding this comment.
Consider consistency of user prompt language. Also think about ways to make this input-getting process more efficient, perhaps using a loop, data structure, etc.
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" |
Collaborator
There was a problem hiding this comment.
What did you mean by this comment? It's a bit confusing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.