Conversation
lili4x4
left a comment
lili4x4
left a comment
There was a problem hiding this comment.
Left some comments on refactoring and requirements
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): |
There was a problem hiding this comment.
This while loop would not loop the required times (10). Consider using a for loop instead since we know how many times we want to iterate.
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
There was a problem hiding this comment.
Consider making this a function, maybe with helper functions to gather user input and print out the story.
| // All the questions that the program asks the user | ||
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Great job including all the required inputs! I like how you worded the input statements for the user.
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 |
There was a problem hiding this comment.
Consider adding some unit tests to ensure the code works as expected.
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
There was a problem hiding this comment.
This isn't commented out. Comment this correct with #
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 |
There was a problem hiding this comment.
Punctuation is not properly spaced through out the text. Consider using an f string. You may also want to consider using \n to create a multi-line string.
Also review the text on line 19.
Please review entire text for grammatical correctness.
3 participants
No description provided.