Conversation
tgoslee
commented
May 13, 2022
Owner
Author
tgoslee
left a comment
tgoslee
left a comment
There was a problem hiding this comment.
Hey, I reviewed your code and I have a few suggestions on how you can refactor what you have.
Comment on lines
2
to
14
| verb_1 = input("Enter a verb of choice, and press enter:") | ||
| adj_1 = input("Enter a adjective of choice, and press enter:") | ||
| verb_2 = input("Enter second verb of choice, and press enter:") | ||
| body_part = input("Enter a body part name of choice, and press enter:") | ||
| adverb = input("Enter an adverb of choice, and press enter:") | ||
| body_part_2 = input("Enter any body name of your choice,and press enter:") | ||
| noun = input("Enter a noun of choice, and press enter:") | ||
| verb_3 = input("Enter the third verb of choice, and press enter:") | ||
| animal = input("Enter name of any animal of choice, and press enter:") | ||
| noub_2 = input("Enter an noun of choice , and press enter:") | ||
| verb_4 = input("Enter the fourth verb of choice, and press enter:") | ||
| adj_2 = input("Enter an adjective of choice, and press enter:") | ||
| color = input("Enter any color name, and press enter:") |
Owner
Author
There was a problem hiding this comment.
I wonder if we could store these variables in a dictionary or another data structure.
Owner
Author
There was a problem hiding this comment.
Consider rechecking the requirements. What variables do we actually need to use?
| adj_2 = input("Enter an adjective of choice, and press enter:") | ||
| color = input("Enter any color name, and press enter:") | ||
|
|
||
| story = "Most doctors agree that bicycle of" + verb_1 + " is a/an " + adj_1 + " form of exercise." + verb_2 +" a bicycle enables you to develop your " + body_part + " muscles as well as " + adverb + " increase the rate of a " + body_part_2 + " beat. More " + noun + " around the world "+ verb_3 +" bicycles than drive "+ animal +". No matter what kind of "+ noun_2 +"you "+ verb_4 + ", always be sure to wear a/an " +adj_2+ " helmet.Make sure to have " + color + " reflectors too! " |
Owner
Author
There was a problem hiding this comment.
This might be more legible as an f string. Also, consider breaking it up into separate lines?
|
|
||
| story = "Most doctors agree that bicycle of" + verb_1 + " is a/an " + adj_1 + " form of exercise." + verb_2 +" a bicycle enables you to develop your " + body_part + " muscles as well as " + adverb + " increase the rate of a " + body_part_2 + " beat. More " + noun + " around the world "+ verb_3 +" bicycles than drive "+ animal +". No matter what kind of "+ noun_2 +"you "+ verb_4 + ", always be sure to wear a/an " +adj_2+ " helmet.Make sure to have " + color + " reflectors too! " | ||
|
|
||
| print(story) |
Owner
Author
There was a problem hiding this comment.
This could also be a function it could start off like:
def generate_mad_lin():
tgoslee
commented
May 13, 2022
tgoslee
commented
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.