Skip to content

Foreman expects LDAP server to follow RFC2307#3287

Merged
aneta-petrova merged 1 commit intotheforeman:3.10from
aneta-petrova:SAT-25037_ldap_schema_3-10
Sep 17, 2024
Merged

Foreman expects LDAP server to follow RFC2307#3287
aneta-petrova merged 1 commit intotheforeman:3.10from
aneta-petrova:SAT-25037_ldap_schema_3-10

Conversation

@aneta-petrova
Copy link
Member

What changes are you introducing?

The same change as in #3277, but for branches 3.10 and earlier.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

N/A

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

N/A

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@github-actions
Copy link

@aneta-petrova aneta-petrova added the tech review done No issues from the technical perspective label Sep 17, 2024
@aneta-petrova
Copy link
Member Author

The update itself was tech reviewed in #3277 so I'm setting tech review done right away.

@maximiliankolb Can you please take a quick look here? Is it okay to add the requirement like this for earlier versions?

@aneta-petrova aneta-petrova added the Needs style review Requires a review from docs style/grammar perspective label Sep 17, 2024
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM

@aneta-petrova aneta-petrova added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Sep 17, 2024
@aneta-petrova aneta-petrova merged commit 45a37d4 into theforeman:3.10 Sep 17, 2024
@aneta-petrova aneta-petrova deleted the SAT-25037_ldap_schema_3-10 branch September 17, 2024 17:55
aneta-petrova added a commit that referenced this pull request Sep 17, 2024
aneta-petrova added a commit that referenced this pull request Sep 17, 2024
aneta-petrova added a commit that referenced this pull request Sep 17, 2024
aneta-petrova added a commit that referenced this pull request Sep 17, 2024
aneta-petrova added a commit that referenced this pull request Sep 17, 2024
@aneta-petrova
Copy link
Member Author

Merged to "3.10" and cherry-picked:

9595f56..4dc8a83 3.9 -> 3.9
4dfca9f..674c594 3.8 -> 3.8
5584cf7..72477d8 3.7 -> 3.7
522cc21..241ef1d 3.6 -> 3.6
1b6db56..ec94407 3.5 -> 3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants