fdi.ssh accepts only the value '1'#4635
Open
stejskalleos wants to merge 1 commit intotheforeman:masterfrom
Open
fdi.ssh accepts only the value '1'#4635stejskalleos wants to merge 1 commit intotheforeman:masterfrom
stejskalleos wants to merge 1 commit intotheforeman:masterfrom
Conversation
github-actions
bot
added
Needs tech review
maximiliankolb
added
style review done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
fdi.sshaccepts only the value '1'. Thetruevalue doesn't work.Why are you introducing these changes? (Explanation, links to references, issues, etc.)
theforeman/foreman-discovery-image#178
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: