Fixes #38611 - Ldap group membership#641
Merged
ofedoren merged 1 commit intotheforeman:masterfrom Jul 23, 2025
Merged
Conversation
ofedoren
reviewed
Jul 22, 2025
Member
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
Thanks, @adamruzicka, please create a RM ticket and link it to the one from Foreman so we better track the whole effort.
Some suggestions inline:
| field :account, _('Account Username') | ||
| field :base_dn, _('Base DN') | ||
| field :groups_base, _('Groups base DN') | ||
| field :use_netgroups, _('Use Netgroups'), Fields::Boolean |
Member
There was a problem hiding this comment.
This is still present in the response, should we rather just add ldap_group_membership?
We also can mark use_netgroups as deprecated in case we're going to drop that:
field :ldap_group_membership, _('LDAP group membership')
field :use_netgroups, _('Use Netgroups'), Fields::Boolean, :replaced_by => [_('Account'), _('LDAP group membership')].join('/')
Contributor
Author
There was a problem hiding this comment.
That's neat, added
adamruzicka
force-pushed
the
ldap-rfc4519
branch
from
da836c6 to
5cc0c41
Compare
adamruzicka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until the main PR (theforeman/foreman#10527) settles