Refactor code/tests to apply almost rubocop rules#60
Open
nthachus wants to merge 15 commits intotheforeman:masterfrom
Open
Refactor code/tests to apply almost rubocop rules#60nthachus wants to merge 15 commits intotheforeman:masterfrom
rubocop rules#60nthachus wants to merge 15 commits intotheforeman:masterfrom
Conversation
- Correct `Rakefile` to skip helpers while running unit-tests
- Remove unnecessary `active_support` from dependencies
- Remove unnecessary instance variables by using `config` property - Add optional parameter `only` into `find_*` methods to get one result - Refactor all unit-tests to apply almost `rubocop` rules
- Add more tests to cover almost logic cases - Optimize method `users_for_gid` to call `find_group` one-times only
… correctly - Support AD binding with an email like `username@domain` - Fix circle-loop when biding with configured `service_user` - Do not lowercase the result login / group names
- Add `attr_member` config to correct Posix LDAP groups finding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
travisconfiguration to test on jRubygemspecfile to manage dependencies instead ofGemfilevendor/bundlepathLdapFluffto the root of Gem lib-pathRakefileto skip helpers while running unit-testsrubocopconfiguration file to use almost rulesldap_test_helperto the test root as a unit-test entrypointactive_supportfrom dependenciesis_in_groups?touser_in_groups?byrubocoprecommendationconfigpropertyrubocoprulesonlyintofind_*methods to get one result*_filter(e.g. group_filter) to createNet::LDAP::Filterusers_for_gidto callfind_groupone-times only