Skip to content

Refactor code/tests to apply almost rubocop rules#60

Open
nthachus wants to merge 15 commits intotheforeman:masterfrom
nthachus:master
Open

Refactor code/tests to apply almost rubocop rules#60
nthachus wants to merge 15 commits intotheforeman:masterfrom
nthachus:master

Conversation

@nthachus
Copy link

  • Change travis configuration to test on jRuby
  • Update gemspec file to manage dependencies instead of Gemfile
  • Use editor configuration file to maintain consistent coding styles
  • Add development guide into README file
  • Update git-ignore file to ignore vendor/bundle path
  • Move class LdapFluff to the root of Gem lib-path
  • Correct Rakefile to skip helpers while running unit-tests
  • Update rubocop configuration file to use almost rules
  • Move ldap_test_helper to the test root as a unit-test entrypoint
  • Reformat all source-code
  • Remove unnecessary active_support from dependencies
  • Rename method is_in_groups? to user_in_groups? by rubocop recommendation
  • Remove unnecessary instance variables by using config property
  • Refactor all code/tests to apply almost rubocop rules
  • Add optional parameter only into find_* methods to get one result
  • Use base method *_filter (e.g. group_filter) to create Net::LDAP::Filter
  • Optimize method users_for_gid to call find_group one-times only
  • Add more tests to cover almost logic cases

- Correct `Rakefile` to skip helpers while running unit-tests
- Remove unnecessary `active_support` from dependencies
- Remove unnecessary instance variables by using `config` property
- Add optional parameter `only` into `find_*` methods to get one result
- Refactor all unit-tests to apply almost `rubocop` rules
- Add more tests to cover almost logic cases
- Optimize method `users_for_gid` to call `find_group` one-times only
… correctly

- Support AD binding with an email like `username@domain`
- Fix circle-loop when biding with configured `service_user`
- Do not lowercase the result login / group names
- Add `attr_member` config to correct Posix LDAP groups finding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant