Fixing find_by_dn issue returning multiple results #62
Open
degetz wants to merge 9 commits intotheforeman:masterfrom
Open
Fixing find_by_dn issue returning multiple results #62degetz wants to merge 9 commits intotheforeman:masterfrom
degetz wants to merge 9 commits intotheforeman:masterfrom
Conversation
replacing inaccurate find_by_dn with a better solution. Issue is original search can return duplicates: CN=joe,OU=base,DC=xyz CN=joe,OU=test,OU=base,DC=xyz will both be present when looking for CN=joe using OU=base,DC=xyz as search base. Since it only wants to retrieve an object identified by the DN using that as the base of the search with the scope base feels more appropriate.
Update generic_member_service.rb
degetz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replacing inaccurate find_by_dn with a better solution.
Issue is: original search can return duplicates:
CN=joe,OU=base,DC=xyz
CN=joe,OU=test,OU=base,DC=xyz
will both be present when looking for CN=joe using OU=base,DC=xyz as search base. Since it only wants to retrieve an object identified by the DN using that as the base of the search with the scope base feels more appropriate.