Fix flaky tests by cleaning a polluted state.#181
Open
sturmianseq wants to merge 2 commits intothegetty:masterfrom
Open
Fix flaky tests by cleaning a polluted state.#181sturmianseq wants to merge 2 commits intothegetty:masterfrom
sturmianseq wants to merge 2 commits intothegetty:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR is to fix flaky tests
tests/test_model.py::TestMagicMethods::test_not_multiple_instance,tests/test_model.py::TestMagicMethods::test_validate_multiplicityafter runningtests/test_model.py::TestAutoIdentifiers::test_bad_autoid, but pass when they are run in isolation.Reproduce the test failure
Run the following command:
Expexted result
Test
tests/test_model.py::TestMagicMethods::test_not_multiple_instanceandtests/test_model.py::TestMagicMethods::test_validate_multiplicityshould pass after runningtests/test_model.py::TestAutoIdentifiers::test_bad_autoid.Actual result
tests/test_model.py::TestMagicMethods::test_not_multiple_instanceandtests/test_model.py::TestMagicMethods::test_validate_multiplicityfail:Why they fail
model.factory.auto_id_typeis polluted aftertests/test_model.py::TestAutoIdentifiers::test_bad_autoidFix
Reset
model.factory.auto_id_typetoint-per-segmentat the end oftests/test_model.py::TestAutoIdentifiers::test_bad_autoidto avoid flaky tests.