Open
Conversation
f120224 to
2954386
Compare
75bec9b to
a130705
Compare
a130705 to
f0d96c0
Compare
f0d96c0 to
19a70c5
Compare
19a70c5 to
c406aca
Compare
Open
|
I tried this but found the GLSL updates were not being rendered. To fix it, I changed In the gamma change handler in my top-level script that calls OpenSeadragonGL, I set the gamma to a new value and then add a call to Now changing the gamma updates the display instantly, which is lovely. As a further improvement, it would be good to flag when the input parameters to GLSL change, so that the tile-drawing callback only invokes GLSL when required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now copy the rendered canvas before any application of shaders. Then, all shaders take the original rendered canvas as input for every subsequent update to the tiles. This allows interactive updating of parameters passed to the shaders.
Additionally, the world is updating on init of openSeadragonGL. Previously, one could only observe the effect of the shaders if the openseadragon world happened to update after the init of openSeadragonGL due to interaction or loading of tiles.