Skip to content

Conversation

@brucejo75
Copy link
Contributor

@brucejo75 brucejo75 commented May 31, 2020

Fixes #59

This is a fairly major change.

  1. Swapped out all jquery calls for native document calls.
  2. Changed the animation to depend on animate.css, which is included in the project. (Might want to keep it out? let the caller include animate.css, like fontawesome?)
  3. Also, because of the major changes. I did a few refactoring items...
  • use requestAnimationFrame instead of setting a timeout
  • Completely refactored setBertOnSession for what was a good reason during development, but as my design finished the good reason disappeared.

Functionality/API should be exactly the same.

@cleverbeagle
Copy link
Collaborator

Looking at this now @brucejo75. Looks like the layout is broken. The alert is flush against the browser edge but should have a ~10-20px gap like the current version.

@brucejo75
Copy link
Contributor Author

@cleverbeagle, OK found my mistake and repaired...

@brucejo75
Copy link
Contributor Author

@cleverbeagle, got rid of merge conflict... good to go.

@brucejo75
Copy link
Contributor Author

@cleverbeagle, any chance this could get merged?

@cleverbeagle
Copy link
Collaborator

@brucejo75 looking now but having some trouble running the code. Do you know what Meteor, Node, and NPM versions you tested against? The error I'm getting is fairly ambiguous but seems to be an issue with one of those versions.

@brucejo75
Copy link
Contributor Author

brucejo75 commented Mar 28, 2021

Hi @cleverbeagle,

I am running this against meteor v1.10.2. I think the newest keyword I used was import, maybe that is an issue on really old versions of Meteor?

Maybe this is a breaking change for really old versions?

Can you forward me some of the errors and your meteor version? I can check it out... maybe I am using some other constructs that need to be removed for older versions of meteor. (class keyword?)

@brucejo75
Copy link
Contributor Author

@cleverbeagle, any status? Thanks!

@brucejo75
Copy link
Contributor Author

@cleverbeagle, @themeteorchef, any chance we could get this merged?

@muikku
Copy link

muikku commented Jun 24, 2022

Should I get rid of Bert or wait for this merge 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bert is codependent on jquery

3 participants