-
Notifications
You must be signed in to change notification settings - Fork 28
Fix 59 bert jquery codependence #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix 59 bert jquery codependence #61
Conversation
|
Looking at this now @brucejo75. Looks like the layout is broken. The alert is flush against the browser edge but should have a ~10-20px gap like the current version. |
|
@cleverbeagle, OK found my mistake and repaired... |
|
@cleverbeagle, got rid of merge conflict... good to go. |
|
@cleverbeagle, any chance this could get merged? |
|
@brucejo75 looking now but having some trouble running the code. Do you know what Meteor, Node, and NPM versions you tested against? The error I'm getting is fairly ambiguous but seems to be an issue with one of those versions. |
|
Hi @cleverbeagle, I am running this against Maybe this is a breaking change for really old versions? Can you forward me some of the errors and your meteor version? I can check it out... maybe I am using some other constructs that need to be removed for older versions of |
|
@cleverbeagle, any status? Thanks! |
|
@cleverbeagle, @themeteorchef, any chance we could get this merged? |
|
Should I get rid of Bert or wait for this merge 🤔 |
Fixes #59
This is a fairly major change.
animate.css, which is included in the project. (Might want to keep it out? let the caller includeanimate.css, likefontawesome?)setBertOnSessionfor what was a good reason during development, but as my design finished the good reason disappeared.Functionality/API should be exactly the same.