Replace afterMarkRecentWrite with afterSingleflightEnd #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test hooks to better represent the actual execution flow by replacing afterMarkRecentWrite with afterSingleflightEnd. The hook is moved from inside markRecentWrite (which only tracks write timestamp) to after the singleflight result is received, providing a more accurate signal for when singleflight operations complete.
- Renamed test hook from
afterMarkRecentWritetoafterSingleflightEndfor semantic clarity - Moved hook invocation from
markRecentWritetofetchFromUpstreamWithSFKeyafter receiving singleflight result - Updated test comments to reflect the actual behavior being tested
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client.go | Renamed test hook field and moved invocation from markRecentWrite to after singleflight completion in fetchFromUpstreamWithSFKey |
| double_check_test.go | Updated test hook name and clarified comments to reflect testing of complete singleflight execution |
| ristretto.go | Added documentation comments explaining cache write behavior and buffer processing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Related issues
Notes for reviewer