Skip to content

Make TimeSpan::__construct() public #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vudaltsov merged 3 commits into from
Oct 6, 2025
Merged

Make TimeSpan::__construct() public #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a9b6b2
Make TimeSpan::__construct() public
vudaltsov Oct 6, 2025
1418465
Add constructor test
vudaltsov Oct 6, 2025
050f31c
Add testConstructorWithoutArgs()
vudaltsov Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/TimeSpan.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@

$nanoseconds = \sprintf('%.0f', round($nanoseconds));

if ($nanoseconds > 0 && self::comparePositiveNumericStrings($nanoseconds, (string) PHP_INT_MAX) > 0

Check warning on line 53 in src/TimeSpan.php

View workflow job for this annotation

GitHub Actions / check / infection 

Escaped Mutant for Mutator "GreaterThan":

@@ @@
             return new self($nanoseconds);
         }
         $nanoseconds = \sprintf('%.0f', round($nanoseconds));
-        if ($nanoseconds > 0 && self::comparePositiveNumericStrings($nanoseconds, (string) PHP_INT_MAX) > 0 || $nanoseconds < 0 && self::compareNegativeNumericStrings($nanoseconds, (string) PHP_INT_MIN) < 0) {
+        if ($nanoseconds > 0 && self::comparePositiveNumericStrings($nanoseconds, (string) PHP_INT_MAX) >= 0 || $nanoseconds < 0 && self::compareNegativeNumericStrings($nanoseconds, (string) PHP_INT_MIN) < 0) {
             throw new \OutOfBoundsException('The specified time span cannot be expressed as integer nanoseconds due to overflow.');
         }
         return new self((int) $nanoseconds);

Check warning on line 53 in src/TimeSpan.php

View workflow job for this annotation

GitHub Actions / check / infection 

Escaped Mutant for Mutator "GreaterThan":

@@ @@
             return new self($nanoseconds);
         }
         $nanoseconds = \sprintf('%.0f', round($nanoseconds));
-        if ($nanoseconds > 0 && self::comparePositiveNumericStrings($nanoseconds, (string) PHP_INT_MAX) > 0 || $nanoseconds < 0 && self::compareNegativeNumericStrings($nanoseconds, (string) PHP_INT_MIN) < 0) {
+        if ($nanoseconds >= 0 && self::comparePositiveNumericStrings($nanoseconds, (string) PHP_INT_MAX) > 0 || $nanoseconds < 0 && self::compareNegativeNumericStrings($nanoseconds, (string) PHP_INT_MIN) < 0) {
             throw new \OutOfBoundsException('The specified time span cannot be expressed as integer nanoseconds due to overflow.');
         }
         return new self((int) $nanoseconds);
|| $nanoseconds < 0 && self::compareNegativeNumericStrings($nanoseconds, (string) PHP_INT_MIN) < 0

Check warning on line 54 in src/TimeSpan.php

View workflow job for this annotation

GitHub Actions / check / infection 

Escaped Mutant for Mutator "LessThan":

@@ @@
             return new self($nanoseconds);
         }
         $nanoseconds = \sprintf('%.0f', round($nanoseconds));
-        if ($nanoseconds > 0 && self::comparePositiveNumericStrings($nanoseconds, (string) PHP_INT_MAX) > 0 || $nanoseconds < 0 && self::compareNegativeNumericStrings($nanoseconds, (string) PHP_INT_MIN) < 0) {
+        if ($nanoseconds > 0 && self::comparePositiveNumericStrings($nanoseconds, (string) PHP_INT_MAX) > 0 || $nanoseconds < 0 && self::compareNegativeNumericStrings($nanoseconds, (string) PHP_INT_MIN) <= 0) {
             throw new \OutOfBoundsException('The specified time span cannot be expressed as integer nanoseconds due to overflow.');
         }
         return new self((int) $nanoseconds);

Check warning on line 54 in src/TimeSpan.php

View workflow job for this annotation

GitHub Actions / check / infection 

Escaped Mutant for Mutator "LessThan":

@@ @@
             return new self($nanoseconds);
         }
         $nanoseconds = \sprintf('%.0f', round($nanoseconds));
-        if ($nanoseconds > 0 && self::comparePositiveNumericStrings($nanoseconds, (string) PHP_INT_MAX) > 0 || $nanoseconds < 0 && self::compareNegativeNumericStrings($nanoseconds, (string) PHP_INT_MIN) < 0) {
+        if ($nanoseconds > 0 && self::comparePositiveNumericStrings($nanoseconds, (string) PHP_INT_MAX) > 0 || $nanoseconds <= 0 && self::compareNegativeNumericStrings($nanoseconds, (string) PHP_INT_MIN) < 0) {
             throw new \OutOfBoundsException('The specified time span cannot be expressed as integer nanoseconds due to overflow.');
         }
         return new self((int) $nanoseconds);
) {
throw new \OutOfBoundsException('The specified time span cannot be expressed as integer nanoseconds due to overflow.');
}
Expand Down Expand Up @@ -135,8 +135,8 @@
return $timeSpan;
}

private function __construct(
private int $nanoseconds,
public function __construct(
private int $nanoseconds = 0,
) {}

public function toNanoseconds(): int
Expand Down
21 changes: 21 additions & 0 deletions tests/TimeSpanTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,27 @@ public function testItThrowsForDateTimeInterfaceDiffInterval(): void
TimeSpan::fromInterval($interval);
}

#[TestWith([0])]
#[TestWith([100])]
#[TestWith([-100])]
#[TestWith([PHP_INT_MAX])]
#[TestWith([PHP_INT_MIN])]
#[TestWith([9_223_372_036_854_775_000])]
#[TestWith([-9_223_372_036_854_775_000])]
public function testConstructor(int $nanoseconds): void
{
$span = new TimeSpan($nanoseconds);

self::assertSame($nanoseconds, $span->toNanoseconds());
}

public function testConstructorWithoutArgs(): void
{
$span = new TimeSpan();

self::assertSame(0, $span->toNanoseconds());
}

#[TestWith([0, 0])]
#[TestWith([0.0, 0])]
#[TestWith([100, 100])]
Expand Down