-
Notifications
You must be signed in to change notification settings - Fork 137
Feat/tutorial self enrolment #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.x
Are you sure you want to change the base?
Feat/tutorial self enrolment #415
Conversation
Triet-coder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tutorial self-enrolment flow works smoothy — I enabled it as admin, picked a stream, then as student saw the correct tutorial list (campus filtering behaved). No regressions in task editor or modal; buttons/disable states are solid. Tiny nit: maybe add a debounce on options load + a test for “no tutorials available”.
ibi420
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
After reviewing this, I can confirm your code is well-written. The UI components align with OnTrack’s design guidelines and maintain consistency with its color scheme. The feature also functions as expected. Good work on this.
WaelAlahamdi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @disururathnayake, I have reviewed the PR and everything works as expected. The implementation is clear and consistent, approved.
Thank you for the work.
Pasindufdo98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@disururathnayake
I tested this with the linked API backend and the tutorial self-enrolment flow worked as expected. The enrolment form displayed correctly, and I was able to complete the workflow without errors. Everything looks good - approved
Description
This feature will allow staff to enable the "Tutorial self enrolment" feature for a designated task. Staff will select which tutorial stream(s) to fetch the tutorials from, and students will be prompted with the list of tutorials they must choose from to complete the task.
To test this feature setup this PR as the backend -thoth-tech/doubtfire-api#64
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Testing Checklist:
Checklist: