Skip to content

Conversation

@Broccoli811
Copy link

Description

The goal was to implement new test cases for a function called hsb_color from the color.cpp file to the unit_test_color.cpp file.

To extend this task; I modified the color documentation file for logging and clamping

The Test case is named: "hsb_color converts HSB to RGB correctly". The associated test tag is "hsb_color"

Type of change

  • [✓] Adding new Test cases
  • [✓] Updated color.cpp Documentation

How Has This Been Tested?

I have tested this using the documentation as a guide. CMake operations were used to test if certain colors were a certain correct value.

Also added a test for out-of-bounds values

Testing Checklist

  • [✓] Tested with sktest
  • [✓] Tested with skunit_tests

Checklist

  • [✓] My code follows the style guidelines of this project
  • [✓] I have performed a self-review of my own code
  • [✓] I have made corresponding changes to the documentation
  • [✓] My changes generate no new warnings

Copy link
Author

@Broccoli811 Broccoli811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy of the a diffrent pull request because I have messed up on the previous pull request where it was merging from my "main" branch instead of the correct branch

Copy link

@monicavtasmin monicavtasmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct branch has been swapped. approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants