Fix zos urls #2576
Closed
Fix zos urls #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
Omarabdul3ziz,
ashraffouda,
muhamadazmy,
rawdaGastan and
xmonader
as code owners
Signed-off-by: Ashraf Fouda <ashraf.m.fouda@gmail.com>
Signed-off-by: Ashraf Fouda <ashraf.m.fouda@gmail.com>
ashraffouda
reviewed
Jul 23, 2025
| // we only care about possibility of establishing a connection | ||
| // so just establishing a connection then close it is good enough | ||
| for _, address := range []string{"bootstrap.grid.tf:http", "hub.grid.tf:http"} { | ||
| for _, address := range []string{"bootstrap.threefold.me:http", "hub.threefold.me:http"} { |
Collaborator
There was a problem hiding this comment.
this should come from zos-config instead , also all urls should come from zos-config
Collaborator
|
all urls in this pr should come from zos-config this was done to fix the issue when name.com decided to stop our *.tf domains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes introduced by this PR and what does it affect
Changes
List of changes this PR includes
Related Issues
List of related issues
Checklist