Update modules on config update #38

Eslam-Nawara · 2025-07-02T14:22:52Z

Description

support modules updating substrate/relay connections if the url in zos-config was updated.

Changes

add update function in substrate-gateway to update substrate connection
add update function in events package to update substrate connection
update GetSubstrate in env pkg to update used substrate manager on changing sub url

Related Issues

let's get config from zos-config instead of hard coded values zos#2571

Checklist

Tests included
Build pass
Documentation
Code format and docstring

ashraffouda · 2025-07-23T09:06:57Z

pkg/environment/config.go


-	FlistURL   string `json:"flist_url"`
-	V4FlistURL string `json:"v4_flist_url"`
+	// FlistURL   string `json:"flist_url"`


why did u remove flist url?

flist urls same as storage urls should not be configurable as long as the node will break if they're changed in run time

ashraffouda · 2025-07-23T13:27:40Z

pkg/environment/environment.go

+	if !slices.Equal(subURLs, env.SubstrateURL) {
+		log.Debug().Strs("substrate_urls", env.SubstrateURL).Msg("updating to sub manager with url")
+		subURLs = env.SubstrateURL
 		pool = substrate.NewManager(env.SubstrateURL...)


here u are creating connection everytime getSubstrate is called which is against the original design this should be executed one time better to have another approach than this we should be using one connection all the time, so either we detect if connection is not working we restart the node services if we can reach substrate on another url from zos config something like monitoring

nope, we're not creating a new connection every time it's called, we're creating a new connection every time it's called after the substrate URLs are changed, only then we create the connection

ashraffouda · 2025-07-23T13:28:26Z

pkg/environment/environment.go

-		if flist := config.V4FlistURL; len(flist) > 0 {
-			env.FlistURL = flist
-		}
+		// if flist := config.V4FlistURL; len(flist) > 0 {


this should come from zos-config, no?

check #38 (comment)

…n-config-update

ashraffouda · 2025-07-31T09:10:44Z

pkg/events/redis.go


 func (r *RedisStream) Start(ctx context.Context) {
 	ps := NewProcessor(r.sub, r.process, NewFileState(r.state))
+	r.processor = ps


does this deals with the already started stream? or we close the old one?

ashraffouda · 2025-07-31T09:12:26Z

pkg/events/redis.go


+func (r *RedisStream) UpdateSubstrateManager(sub substrate.Manager) {
+	r.sub = sub
+	r.processor.sub = sub


also here u r just changing sub and u didn't deal with the already started stream

this change will not have any effect on the running connection as long as it is open and healty, if the connection is closed unexpectedly, then new connection will be created with the new manager

ashraffouda · 2025-07-31T12:52:58Z

pkg/events/events.go

+			// if new update is received then the connection is broken as noded only issues new update only if
+			// the old manager is broken so we need to resubscribe with the new manager.
+			e.sub = newSub
+			log.Info().Msg("new substrate manager received, trying to resubscribe to the new manager")


that is not correct u r printing log that there is a new substrate manager that u will try
then after that directly u print an error which will confuse the user for sure
the error should be printed first then the info for trying new connection should come after when u r actually trying

also can u plz print which urls r failing and which urls u r trying?

will remove the log.Info message, will just log that the subscribtion failed and will try again, noded module will log that it was updated successfully once the update is done

also both noded and api-gateway modules logs the new urls that will be used, and the error messages of the modules trying to reach the chain shows the faulty urls

ashraffouda · 2025-07-31T12:55:06Z

pkg/events/events.go

+			// if new update is received then the connection is broken as noded only issues new update only if
+			// the old manager is broken so we need to resubscribe with the new manager.
+			e.sub = newSub
+			log.Info().Msg("new substrate manager received, trying to resubscribe to the new manager")


also can u plz print which urls r failing and which urls u r trying?

Eslam-Nawara requested review from Omarabdul3ziz, ashraffouda, muhamadazmy, rawdaGastan and xmonader as code owners July 2, 2025 14:22

stop listening changes in storage and flist Changes

2683a49

Eslam-Nawara force-pushed the update-modules-on-config-update branch from ebb3e29 to c1ed22b Compare July 7, 2025 10:09

Eslam-Nawara added 5 commits July 7, 2025 13:10

update get substrate to update manager if sub_url changed

55268fa

update events packeage to allow updating sub connection

96ccbc2

update substrate gateway to allow updating sub connection

8cafa89

remove unused poolOnce

5e9fb91

stop listening changes in storage and flist Changes

7af2de7

Eslam-Nawara force-pushed the update-modules-on-config-update branch from c1ed22b to 7af2de7 Compare July 7, 2025 10:10

Eslam-Nawara force-pushed the load-config-urls-from-zos-config branch from 2683a49 to 67517d3 Compare July 7, 2025 10:12

Eslam-Nawara added 2 commits July 9, 2025 17:16

update rmb to latest

88609be

use atomic bool for update in events.go

51aa984

Eslam-Nawara mentioned this pull request Jul 9, 2025

Update modules to update with config threefoldtech/zos#2583

Merged

4 tasks

ashraffouda requested changes Jul 23, 2025

View reviewed changes

Eslam-Nawara added 2 commits July 23, 2025 17:53

Merge branch 'load-config-urls-from-zos-config' into update-modules-o…

ba68d81

…n-config-update

update only if sub connection is broken

45454a7

Eslam-Nawara force-pushed the update-modules-on-config-update branch 3 times, most recently from 55db330 to fc867d1 Compare July 29, 2025 13:08

set pool value if it is nil

a6949c3

Eslam-Nawara force-pushed the update-modules-on-config-update branch from fc867d1 to a6949c3 Compare July 29, 2025 13:09

ashraffouda approved these changes Jul 31, 2025

View reviewed changes

ashraffouda requested changes Jul 31, 2025

View reviewed changes

Base automatically changed from load-config-urls-from-zos-config to main July 31, 2025 09:12

Eslam-Nawara added 2 commits July 31, 2025 13:51

update events to check connection if new update receved

b902e4f

resubscribe if noded issued new update for events handler

0a6d26d

Eslam-Nawara force-pushed the update-modules-on-config-update branch from 7692ea4 to de1de8a Compare July 31, 2025 12:24

ashraffouda requested changes Jul 31, 2025

View reviewed changes

initialize update chan before using it

b41b6f5

Eslam-Nawara force-pushed the update-modules-on-config-update branch from de1de8a to b41b6f5 Compare July 31, 2025 13:23

ashraffouda approved these changes Jul 31, 2025

View reviewed changes

Eslam-Nawara merged commit 3e77601 into main Jul 31, 2025
1 check failed

Eslam-Nawara deleted the update-modules-on-config-update branch July 31, 2025 13:40

Update modules on config update #38

Update modules on config update #38

Uh oh!

Conversation

Eslam-Nawara commented Jul 2, 2025

Description

Changes

Related Issues

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants