fix flistd cleanup #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
Omarabdul3ziz,
ashraffouda,
muhamadazmy,
rawdaGastan and
xmonader
as code owners
ashraffouda
requested changes
Jul 13, 2025
Eslam-Nawara
force-pushed
the
fix-flistd-cleanup
branch
from
5087b9d to
06e9d4b
Compare
ashraffouda
requested changes
Jul 13, 2025
| log.Warn().Err(err).Msgf("normal unmount failed for %s, trying lazy unmount", path) | ||
|
|
||
| // try lazy unmount | ||
| err = f.system.Unmount(path, syscall.MNT_DETACH) |
Collaborator
There was a problem hiding this comment.
this is not force unmount that is lazy unmount which is something diff from the method name
so I suggest u try to unmount if not try force unmount if u really want to force unmount
err := syscall.Unmount("/mnt/my-mount", syscall.MNT_FORCE)
or change method name to reflect u r doing lazy unmount but sure this needs some testing to check if force unmount will slove it or not
Contributor
Author
There was a problem hiding this comment.
force umount is not supported for the used fs, the force will be ignored, so the safe solution is to use lazy mount, the function name meant to reflect that we forcibly do the clean up, will updated the name to reflect that
ashraffouda
approved these changes
Jul 30, 2025
Eslam-Nawara
force-pushed
the
fix-flistd-cleanup
branch
from
4b06a85 to
ca2c822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
force unmount and remove in flist clean up if the path is not mountpoint but the module can not delete it
Related Issues
threefoldtech/zos#2581
Checklist