remove iperf

docs/cmds/modules/noded.md

@@ -7,18 +7,17 @@ This module is responsible of registering the node on the grid, and handling of
 - Connects to `Redis` message broker over `zbus`
 - Prints **Node ID** or **Node network** if their flags were passed
 - Collects node info:
-    - Node capacity (CPU, memory, disk)
-    - Whether the node is booted via `efi`
-    - `DMI` Info (Desktop Management Interface)
-    - Name of the hypervisor used on the node
-    - List of available GPUs, logs GPUs info
-- Starts a registrar service and publishes node info 
+  - Node capacity (CPU, memory, disk)
+  - Whether the node is booted via `efi`
+  - `DMI` Info (Desktop Management Interface)
+  - Name of the hypervisor used on the node
+  - List of available GPUs, logs GPUs info
+- Starts a registrar service and publishes node info
 - Registers the node on the blockchain
-- Monitor node performance: 
-    - `NTP` check
-    - `iperf` (network performance measurement)
-    - `cpubench` (CPU benchmark)
-    - `public ip` (validity of public ip)
+- Monitor node performance:
+  - `NTP` check
+  - `cpubench` (CPU benchmark)
+  - `public ip` (validity of public ip)
 - Streams events to the blockchain
 - Keeps track of environment changes (substrate URLs)
 
@@ -38,8 +37,8 @@ noded --net
 
 ### Command-line flags
 
-| Flag       | Description                                     | Default                     |
-| ---------- | ----------------------------------------------- | --------------------------- |
-| `--broker` | Connection string to the message BROKER         | `unix:///var/run/redis.sock`|
-| `--id`     | print node id and exit                          | false                       |
-| `--net`    | print node network and exit                     | false                       |
+| Flag       | Description                             | Default                      |
+| ---------- | --------------------------------------- | ---------------------------- |
+| `--broker` | Connection string to the message BROKER | `unix:///var/run/redis.sock` |
+| `--id`     | print node id and exit                  | false                        |
+| `--net`    | print node network and exit             | false                        |

docs/tasks/README.md

@@ -37,7 +37,6 @@ To ensure that the node always has a test result available, a check is performed
     - `"public-ip-validation"`
     - `"cpu-benchmark"`
     - `"healthcheck"`
-    - `"iperf"`
 
   - Return: a single task result.
 
@@ -71,4 +70,3 @@ Notes:
 - [Public IP validation](./publicips.md)
 - [CPU benchmark](./cpubench.md)
 - [Health Check](./healthcheck.md)
-- [IPerf](./iperf.md)

pkg/netlight/public/public.go

@@ -16,7 +16,6 @@ import (
 	"github.com/threefoldtech/zosbase/pkg/netlight/bootstrap"
 	"github.com/threefoldtech/zosbase/pkg/netlight/bridge"
 	"github.com/threefoldtech/zosbase/pkg/netlight/ifaceutil"
-	"github.com/threefoldtech/zosbase/pkg/netlight/iperf"
 	"github.com/threefoldtech/zosbase/pkg/netlight/macvlan"
 	"github.com/threefoldtech/zosbase/pkg/netlight/namespace"
 	"github.com/threefoldtech/zosbase/pkg/netlight/options"
@@ -380,9 +379,6 @@ func EnsurePublicSetup(nodeID pkg.Identifier, vlan *uint16, inf *pkg.PublicConfi
 			return nil, errors.Wrap(err, "failed to ensure public namespace setup")
 		}
 
-		if err := iperf.Ensure(zinit.Default()); err != nil {
-			return nil, errors.Wrap(err, "failed to ensure iperf service")
-		}
 	}
 
 	return br, netlink.LinkSetUp(br)

pkg/network/networker.go

@@ -24,7 +24,6 @@ import (
 	"github.com/threefoldtech/zosbase/pkg/gridtypes/zos"
 	"github.com/threefoldtech/zosbase/pkg/netbase/wireguard"
 	"github.com/threefoldtech/zosbase/pkg/network/bootstrap"
-	"github.com/threefoldtech/zosbase/pkg/network/iperf"
 	"github.com/threefoldtech/zosbase/pkg/network/mycelium"
 	"github.com/threefoldtech/zosbase/pkg/network/ndmz"
 	"github.com/threefoldtech/zosbase/pkg/network/options"
@@ -124,7 +123,7 @@ func NewNetworker(identity *stubs.IdentityManagerStub, ndmz ndmz.DMZ, ygg *yggdr
 	// always add the reserved yggdrasil and mycelium ports to the port set so we make sure they are never
 	// picked for wireguard endpoints
 	// we also add http, https, and traefik metrics ports 8082 to the list.
-	for _, port := range []int{yggdrasil.YggListenTCP, yggdrasil.YggListenTLS, yggdrasil.YggListenLinkLocal, mycelium.MyListenTCP, iperf.IperfPort, 80, 443, 8082} {
+	for _, port := range []int{yggdrasil.YggListenTCP, yggdrasil.YggListenTLS, yggdrasil.YggListenLinkLocal, mycelium.MyListenTCP, 80, 443, 8082} {
 		if err := nw.portSet.Add(uint(port)); err != nil && errors.Is(err, set.ErrConflict{}) {
 			return nil, err
 		}

pkg/network/public/public.go

@@ -16,7 +16,6 @@ import (
 	"github.com/threefoldtech/zosbase/pkg/network/bootstrap"
 	"github.com/threefoldtech/zosbase/pkg/network/bridge"
 	"github.com/threefoldtech/zosbase/pkg/network/ifaceutil"
-	"github.com/threefoldtech/zosbase/pkg/network/iperf"
 	"github.com/threefoldtech/zosbase/pkg/network/macvlan"
 	"github.com/threefoldtech/zosbase/pkg/network/namespace"
 	"github.com/threefoldtech/zosbase/pkg/network/options"
@@ -380,9 +379,6 @@ func EnsurePublicSetup(nodeID pkg.Identifier, vlan *uint16, inf *pkg.PublicConfi
 			return nil, errors.Wrap(err, "failed to ensure public namespace setup")
 		}
 
-		if err := iperf.Ensure(zinit.Default()); err != nil {
-			return nil, errors.Wrap(err, "failed to ensure iperf service")
-		}
 	}
 
 	return br, netlink.LinkSetUp(br)

pkg/perf/cache_test.go

@@ -227,7 +227,6 @@ func TestGenerateKey(t *testing.T) {
 		{"cpu-benchmark", "perf.cpu-benchmark"},
 		{"public-ip-validation", "perf.public-ip-validation"},
 		{"healthcheck", "perf.healthcheck"},
-		{"iperf", "perf.iperf"},
 		{"", "perf."},
 	}