Build previews using dapp-development tagged packages
#147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
There are situations when team developing T Token Dashboard needs to
locally test some functionalities using modified contracts, for example
ones with shorter authorization decrease delay. We decided to create a
dapp-developmentbranch in each of the expected upstream modules ofthe
threshold-network/token-dashboardCI module, which would storethe code of these modified contracts. (Although currently there's no
@keep-network/random-beacon,@keep-network/ecdsaand@keep-network/tbtc-v2dependencies in the T dashboard yet, they'reexpected to be added soon and we are already preparing for that).
Repositories with
dapp-developmentbranch containing modifiedcontracts:
threshold-network/solidity-contractskeep-network/keep-corekeep-network/tbtc-v2Using the code from the
dapp-developmentbranch we will buildpackages that will be published to the NPM registry under
dapp-development-<environment>tag and withdappdev<environment>suffix (
<environment>currently beinggoerli).Generally, the goal of the changes is to have the full set of
dapp-development-friendly contracts deployed to the NPM registry, so
that they could be used to create dApp previews that will be easily
testable. The dApp developers could also use the contracts to build
dashboard on their local envirionment by upgrading the
token-dashboarddependencies usingyarn upgrade <package-name>@dapp-development-goerli.THIS CHANGE:
In this commit/PR we modify the GH Actions job which is used for
publishing of the testnet dashboard to the main and preview testnet
buckets. We're splitting this job into two separate jobs:
build-and-deploy-testnet:Executed after merges to
mainor when dispatched manually.Uses unmodified contracts (tagged
goerli).Publishes testnet dApp to
dashboard.test.threshold.networkbucket.
build-and-deploy-testnet-preview:Executed after PR creation/update.
Uses modified contracts when availible
(tagged
dappdevgoerli).Publishes testnet dApp to
preview.dashboard.test.threshold.networkbucket.Provides link to the preview in PR comment.
TODO:
@keep-network/random-beacon,@keep-network/ecdsaand@keep-network/tbtc-v2contracts if they'll be added as dashboard's dependencies before merge of this PR.dappdevgoerli-tagged packages published in the NPM registry.Refs:
#136
threshold-network/solidity-contracts#119
threshold-network/keep-core#3121
threshold-network/tbtc-v2#392