Draft
Conversation
263c60f to
7296c3c
Compare
7296c3c to
becb80d
Compare
|
I know this hasn't been worked on recently @scorphus , but were there any known issues/incompatibilities? I'm currently upgrading an internal codebase that uses opencv-engine from Thumbor 6->7, and was wondering if this would be suitable for use. If there's any known issues I can take a crack at resolving them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
This PR includes several changes to the codebase not only to make it compatible with Thumbor 7 and Python 3 but also to put the project back on track.
There's some stuff left to do – I just ran out of Ben & Jerry's – but I'd love to collect early reviews, so I'm submitting this as draft.
TODO
Here's a list of things to do (there might be more) starting from the easiest:
./integration_tests/These could also be converted into issues and tackled by any avid bootcamper.