Conversation
|
This build check is failing, does it depend on your previous PR (#269)? |
seems like I had to update |
|
Hi @cleary! Is this PR going to be merged or should I close it? |
|
Just leave it open for the moment - I was attempting to gain some clarity on the status of a bigger rewrite and how we handle changes happening in the meantime. I need to review when I have a bit of spare time |
cleary
left a comment
There was a problem hiding this comment.
Hi,
Thanks for all your work on this, and (massive) apologies that it's taken me so long to review.
The ideas all look good, I think you've moved things appropriately - one minor/optional change request:
In sample_trimming.md: make the "Event-relative" and "Relative to the sample length" headings consistent
The other thing is it's no longer merging cleanly - are you able to take a look at getting the master branch updates in for a clean merge and I will accept
This PR restructures the samplers and sampling pages of the documentation so that groupings make more sense, follow up to PR #269.
SAMPLERS PAGE
ampandgainwere moved from samplers>basic sample manipulation to audio effects.accelerate,speed,unit,timescale, andtimescalewin). I thus renamed samplers to sample_speedSAMPLING PAGE
segment,discretise,sig) to oscillators.loopAtto the previously renamed sample_speed pageThis PR also updates
sidebars.js, which should make the new page of the previous PR appear.