Fix #230: Modify Barrier::wait to return BarrierWaitResult#254
Merged
Fix #230: Modify Barrier::wait to return BarrierWaitResult#254
Conversation
Contributor
|
@r1ru |
Collaborator
|
Can you add test code like this? awkernel/awkernel_async_lib/src/sync/mutex.rs Line 116 in 29c3d31 |
ytakano
reviewed
Dec 12, 2024
veqcc
reviewed
Dec 13, 2024
ytakano
reviewed
Dec 19, 2024
ytakano
reviewed
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make the current implementation of
BarrierAPI compatible with other libraries like tokio, following changes were made.Barrier::waitto returnBarrierWaitResultArcsince it is common to useBarrierstruct wrapped withArcSee
https://doc.rust-lang.org/beta/std/sync/struct.Barrier.html
https://docs.rs/tokio/latest/tokio/sync/struct.Barrier.html