fix(ixgbe): multiple init of IXGBE_CTRL_EXT_DRV_LOAD#278
Merged
Conversation
`IXGBE_CTRL_EXT_DRV_LOAD` of `IXGBE_CTRL_EXT` should be set aftre setting up drivers once. Signed-off-by: Yuuki Takano <ytakanoster@gmail.com>
Koichi98
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IXGBE_CTRL_EXT_DRV_LOADofIXGBE_CTRL_EXTshould be set after setting up the device driver once.Currently, the flag is set up before the driver initialization.
Additionally, it is set up after the driver initialization as follows.
awkernel/awkernel_drivers/src/pcie/intel/ixgbe.rs
Lines 387 to 390 in 00185fa
This PR removes the first set up of
IXGBE_CTRL_EXT_DRV_LOAD.Related links
https://github.com/openbsd/src/blob/8a8057a73cb1964915a1105b223ec749e2c82eb7/sys/dev/pci/if_ix.c#L337-L340
How was this PR tested?
Notes for reviewers