Skip to content

Conversation

@violet4
Copy link

@violet4 violet4 commented Oct 5, 2018

  • I kept it simple for ease of review and merging
  • my friend had a namespace clobber - slate's insert utils imported a different utils
  • I don't know best practices or whether import slate.utils as utils is the best solution, but using such an import never caused issues for me. from . import utils can cause issues when trying to run a code file directly (e.g. python classes.py from the command line) vs importing a module that contains such from . import utils statements from other python code.

…bber when users have another module called 'utils'
@violet4
Copy link
Author

violet4 commented Oct 5, 2018

I see a better solution in #32 from slate import utils described by #32 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant