.NET 10 #245
Open
.NET 10 #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the project to ".NET 10" along with code improvements, formatting fixes via linter/prettier, and a refreshed package-lock.json. However, there are critical issues with the proposed .NET version.
Key Changes:
- Upgrade from .NET 6.0 to .NET 10.0 (problematic - version doesn't exist)
- Port changes from 80 to 8080 across Docker and configuration files
- NuGet package version updates
- Modern C# collection expressions (array/list initializers to collection expressions)
- Code formatting standardization (spaces to tabs in TypeScript/Vue files)
- Serilog API modernization
Reviewed changes
Copilot reviewed 57 out of 178 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| UT4MasterServer/UT4MasterServer.csproj | Target framework changed to net10.0 and NuGet packages updated |
| UT4MasterServer.Xmpp/UT4MasterServer.Xmpp.csproj | Target framework changed to net10.0 |
| UT4MasterServer/Dockerfile | Docker base images updated to use .NET 10.0 runtime and SDK |
| docker-compose.yml, docker-compose.override.yml | Port mappings changed from 80 to 8080 |
| UT4MasterServer/appsettings.json | Kestrel endpoint URL changed to port 8080 |
| Various C# files | Collection initializers modernized to collection expressions |
| UT4MasterServer/Configuration/InternalLoggerConfiguration.cs | Serilog API updated to use WithThreadId() |
| UT4MasterServer.Xmpp/Program.cs | X509Certificate2 loading updated to use X509CertificateLoader |
| UT4MasterServer.sln | Visual Studio version updated to 18 |
| Various TypeScript/Vue files | Formatting changes (spaces to tabs) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some code improvements, fixed linter and prettier and refreshed
package-lock.json.FYI: Not tested with game
FYI2: You can review this PR first: #246 to reduce git diff