Skip to content

Add muli-bot support#1

Open
brutto wants to merge 7 commits intotimkley:mainfrom
brutto:main
Open

Add muli-bot support#1
brutto wants to merge 7 commits intotimkley:mainfrom
brutto:main

Conversation

@brutto
Copy link

@brutto brutto commented Jan 31, 2025

Excellent plugin, thank you for you job.
Add support multibot (in my case) for testing purposes: production vs staging. In other hands maybe in some cases it will be helpful when mm installation has many bots with different deployment (company with many developer's commands each has it's own bot).

@timkley
Copy link
Owner

timkley commented Feb 3, 2025

Hi @brutto, thanks for your PR and the kind words!

The only thing that makes me hesistant is the multiline-configuration. This seems very error-prone. Do you know of another way how there could be a 1 to 1 relationsship between Bot ID and Webhook-URL?

@brutto
Copy link
Author

brutto commented Feb 4, 2025

@timkley agree, make it with courage first )))

Update PR: make parse config more robust via check every config value and throw exceptions on error to see it mattermost on save.

@timkley
Copy link
Owner

timkley commented Feb 7, 2025

@brutto thank you so much, this looks promising! Could you take a look at the workflow failures? My go is not good enough to fix it myself 😅

fix input argument misprint from copy-paste
fix erro handling in config
@brutto
Copy link
Author

brutto commented Feb 9, 2025

Suddenly go also not my primary =) Add `fmt] into import and refactor error handling from config parser: make it more sence.

@timkley
Copy link
Owner

timkley commented Feb 16, 2025

The ci checks still fail..

@kalimanborges
Copy link

My suggestion would be to write the config as a json:
{
botid : url,
boti2 : url2
}

@timkley
Copy link
Owner

timkley commented May 27, 2025

@kalimanborges to my knowledge this is not supported in the UI

@bclermont
Copy link

need this so bad

@bclermont
Copy link

why not just have a json as the value of the mapping between bot and webhook?

@timkley
Copy link
Owner

timkley commented Aug 19, 2025

@bclermont
as said before: it's not supported in the UI..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants