Allow exporting sprites with SingleShapeSVGExporter#37
Open
tuomassalo wants to merge 1 commit intotimknip:masterfrom
tuomassalo:singleshape-sprites-fix
Open
Allow exporting sprites with SingleShapeSVGExporter#37tuomassalo wants to merge 1 commit intotimknip:masterfrom tuomassalo:singleshape-sprites-fix
tuomassalo wants to merge 1 commit intotimknip:masterfrom
tuomassalo:singleshape-sprites-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to use
SingleShapeSVGExporterto export aTagDefineSprite. Without this PR, theget_dependencies()method only gives the id of the sprite itself, thus not adding properdefsentries.To me it would seem logical that all the
TagPlaceObjects inside aTagDefineSpritewould be seen as something that the sprite depends on. Can you see whether this PR could cause a problem elsewhere?Or: should I not try to use
SingleShapeSVGExporterto export a sprite?